-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for packages in $GOPATH/pkg/mod/ for completion. #2936
Conversation
placed in the path.
Everything I 'go get' is placed in $GOPATH/pkg/mod. This location is not currently looked at for package name completion. Without this change (or some similar change) I cannot use package name completion for third-party packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm not sure if this is relevant to the PR (not sure I fully understand it), but the location of the module cache will be determined by the |
Thanks, Rebecca! That is relevant for this PR. |
It's not clear to me what I am supposed to be doing, if anything. I look at the failing test and I don't see how they relate to the change I made. Test_goimports and the routines it calls don't intersect with completion at all AFAICT. If there is something I can do wrt making this more compatible with Go 1.15 I will do that. Is that required for this to be accepted? |
I'm willing to merge this without the GOMODCACHE change: I can add that in a separate PR after merging. I'll take a closer look at the tests this weekend and will merge if the failures aren't relevant to this PR. |
@bhcleek thanks. FWIW I cannot duplicate the test failure. |
Thank you for contributing @WhoIsSethDaniel ! |
Strip out version information placed in the path.