Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for packages in $GOPATH/pkg/mod/ for completion. #2936

Merged
merged 1 commit into from
Jun 27, 2020
Merged

Look for packages in $GOPATH/pkg/mod/ for completion. #2936

merged 1 commit into from
Jun 27, 2020

Conversation

WhoIsSethDaniel
Copy link
Contributor

Strip out version information placed in the path.

@WhoIsSethDaniel
Copy link
Contributor Author

Everything I 'go get' is placed in $GOPATH/pkg/mod. This location is not currently looked at for package name completion. Without this change (or some similar change) I cannot use package name completion for third-party packages.

bhcleek
bhcleek previously approved these changes Jun 25, 2020
Copy link
Collaborator

@bhcleek bhcleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bhcleek bhcleek dismissed their stale review June 25, 2020 22:28

tests are failing

@stamblerre
Copy link
Contributor

I'm not sure if this is relevant to the PR (not sure I fully understand it), but the location of the module cache will be determined by the GOMODCACHE env variable in Go 1.15: golang/go#34527.

@bhcleek
Copy link
Collaborator

bhcleek commented Jun 25, 2020

Thanks, Rebecca! That is relevant for this PR.

@WhoIsSethDaniel
Copy link
Contributor Author

It's not clear to me what I am supposed to be doing, if anything. I look at the failing test and I don't see how they relate to the change I made. Test_goimports and the routines it calls don't intersect with completion at all AFAICT. If there is something I can do wrt making this more compatible with Go 1.15 I will do that. Is that required for this to be accepted?

@bhcleek
Copy link
Collaborator

bhcleek commented Jun 26, 2020

I'm willing to merge this without the GOMODCACHE change: I can add that in a separate PR after merging.

I'll take a closer look at the tests this weekend and will merge if the failures aren't relevant to this PR.

@WhoIsSethDaniel
Copy link
Contributor Author

@bhcleek thanks. FWIW I cannot duplicate the test failure.

@bhcleek bhcleek merged commit 905ed7e into fatih:master Jun 27, 2020
@bhcleek bhcleek added this to the vim-go 1.24 milestone Jun 27, 2020
@bhcleek
Copy link
Collaborator

bhcleek commented Jun 27, 2020

Thank you for contributing @WhoIsSethDaniel !

bhcleek added a commit that referenced this pull request Jun 27, 2020
@WhoIsSethDaniel WhoIsSethDaniel deleted the fix_package_completion branch June 27, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants