debug: refactor sign management #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcleek
force-pushed
the
debug/signs-viml
branch
4 times, most recently
from
c4642ee to
158654a
Compare
Use functions instead of ex commands for managing signs when possible. Put signs in the vim-go-debug group to avoid using the global group except for when the sign functions don't exist; sign groups were introduced in the same commit that introduced the functions to manage signs: vim/vim@162b714.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use functions instead of ex commands for managing signs when possible.
Put signs in the vim-go-debug group to avoid using the global group.