Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Highlight for template's dot-identifier #3189

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fix Highlight for template's dot-identifier #3189

merged 1 commit into from
Apr 1, 2021

Conversation

alker0
Copy link
Contributor

@alker0 alker0 commented Apr 1, 2021

Currently, Dot-identifiers {{ .foo.bar }} are not highlighted.

syn match goTplIdentifier contained /\.[^\s}]+\>/

In character range [a-z] of vim pattern, it is necessary to use [:blank:] as spaces instead of \s.
Also, + needs escape for working as 'one or more' in vim magic pattern (default mode).
This PR fixes it.

@bhcleek bhcleek added this to the vim-go 1.25 milestone Apr 1, 2021
@bhcleek
Copy link
Collaborator

bhcleek commented Apr 1, 2021

Thank you for contributing

The test failures are due to a golangci-lint change that I'm working on fixing and can be ignored for this PR.

@bhcleek bhcleek merged commit a673953 into fatih:master Apr 1, 2021
bhcleek added a commit that referenced this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants