Set shellxquote properly for cmd.exe

[nonsleepr]

I have custom shellxquote in my config and it breaks the plugin. Setting it to quote and restoring after the fact fixes the issue.

[bhcleek]

I'm concerned that this could break others and generally. After reading :help shellxquote, it seems like it would be preferrable for users to set shell rather than vim-go trying to mess with shellquote or shellxquote.

WDYT?

[nonsleepr]

In my case I have the value of shellxquote changed according to this recommendations and that broke vim-go.
If I understand correctly, that custom handling is to fix #2713, it looks like the fix for just didn't set all the settings for cmd.exe.
An alternative is to remove the change made in #2713 and somehow make shell=pwsh work, but it seems for that shellescape in Vim/Neovim has to be changed. I might be wrong.

[bhcleek]

Ah, I see. In that case, should your changes be modified from

      set shellquote=
      set shellxquote=\"

to

      unset shellquote
      unset shellxquote

so that Vim will do the right thing, relying solely on shell?

[nonsleepr]

You're right. That's a better idea.

Tested with the following block to reset everything shell-powershell recommends to change and it works alright:

  if go#util#IsWin()
    set shell&
    set shellredir&
    set shellcmdflag&
    set shellpipe&
    set shellquote&
    set shellxquote&
  endif

Would it make sense to do it everywhere, not only on Windows and just rely on defaults to properly escape arguments?

[bhcleek]

I'm a little hesitant to change more than what we know is needed here, because the blast radius covers more systems than I can test on. For now, let's focus only on the shellquote and shellxquote needs that you've identified.

[nonsleepr]

Makes sense.

Do you think we can add a test global variable which makes the plugin use all defaults?

[bhcleek]

I'm not sure I understand what you mean. Can you clarify?

[nonsleepr]

I mean, have a global variable, like g:go_use_shell_defaults which, when enabled, sets the following and calls system instead of performing custom handling which is done by s:exec:

set shell&
set shellredir&
set shellcmdflag&
set shellpipe&
set shellquote&
set shellxquote&

[bhcleek]

Thanks for clarifying. I don't think we need to introduce a new option yet.

I'll merge these changes soon.

[bhcleek]

Sorry for the long delay; I'd forgotten about this.