Increase compatibility with tcsh #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,7 +196,7 @@ function! go#cmd#Test(bang, compile, ...) | |||
|
|
|||
| if a:0 | |||
| " expand all wildcards(i.e: '%' to the current file name) | |||
| let goargs = map(copy(a:000), "expand(v:val)") | |||
| let goargs = map(copy(a:000), "shellescape(expand(v:val))") | |||
There was a problem hiding this comment.
Can you just add another line below, so it should be like:
let goargs = map(copy(a:000), "expand(v:val)")
let goargs = go#util#Shelllist(goargs, 1)
|
Thanks @tsne for the contribution. My macbook is broken and in service, using a four year old one. Just had time to look at it. |
|
Hi @fatih. Thanks for reviewing. I fixed the issue with the extra line for |
|
Thanks @tsne 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
some of the
:Go*commands report errors when tcsh is configured in Vim. This pull request aims to resolve these errors.I tested the commands with tcsh and sh configured, and here it works fine. Maybe someone else can double check if everything still works smoothly with her/his shell.