Revert backwards incompatible changes to HTTPClient interface #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removed backwards-incompatible changes introduced in v2.4.0: remove the
getURL()
method from theHTTPClient
interface.Full (and accurate!) endpoints are not available at the point of logging for feeds and streams, so I updated the debug message to be the request path instead of full URL.
Bonus:
Motivation and context
In #308, published in v2.4.0, we added some basic logging infrastructure, but that made breaking changes to the
HTTPClient
API. In retrospect, I don't believe those were helpful changes either - ThegetURL()
implementations added to the built-in clients do not change with the request path, so usinggetURL
when you want to gather information for a stream request, for example, it would return the incorrect URL.How was the change tested?
No changes to testing.
Screenshots (if appropriate):
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.