Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert backwards incompatible changes to HTTPClient interface #315

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

ptpaterson
Copy link
Contributor

@ptpaterson ptpaterson commented Dec 18, 2024

Description

This PR removed backwards-incompatible changes introduced in v2.4.0: remove the getURL() method from the HTTPClient interface.

Full (and accurate!) endpoints are not available at the point of logging for feeds and streams, so I updated the debug message to be the request path instead of full URL.

Bonus:

  • Added a debug line to starting stream connection for consistency with query and feed.
  • tidied up imports

Motivation and context

In #308, published in v2.4.0, we added some basic logging infrastructure, but that made breaking changes to the HTTPClient API. In retrospect, I don't believe those were helpful changes either - The getURL() implementations added to the built-in clients do not change with the request path, so using getURL when you want to gather information for a stream request, for example, it would return the incorrect URL.

How was the change tested?

No changes to testing.

Screenshots (if appropriate):

image

image

image

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ptpaterson ptpaterson requested a review from a team December 18, 2024 15:06
@mwilde345 mwilde345 merged commit 41d19fc into main Dec 18, 2024
7 checks passed
@mwilde345 mwilde345 deleted the undo-httpclient-changes branch December 18, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants