Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not retry on 502 #147

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Do not retry on 502 #147

merged 3 commits into from
Sep 5, 2023

Conversation

pnwpedro
Copy link
Collaborator

@pnwpedro pnwpedro commented Sep 5, 2023

Ticket(s): BT-3465

Problem

After some discussion, we're opting to retry only on 429 for now.

Solution

  • Remove retries on 502s.
  • Flatten retry config because it felt inconsistent as is. We can revisit the config story for the driver on a future major release

Result

What will change as a result of your pull request? Note that sometimes this section is unnecessary because it is self-explanatory based on the solution.

Testing

updated tests


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pnwpedro pnwpedro merged commit 616512f into main Sep 5, 2023
@pnwpedro pnwpedro deleted the donottryagain-502 branch September 5, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants