-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial work to support streams #155
Conversation
2e780fc
to
8d00cd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General API use looks correct, I have a question on error handling in the pr.
Also thinking through the restarts a bit, we are going to need to track the last seen transaction ts for each stream the client has open, are we setup to do that as is? We won't want to use the general client transaction ts.
Do we do any sort of integration tests against an actual running fauna in this driver? Would be good to have some actual streaming tests in place and also would make it fairly straight forward to validate the error ux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about avoiding httpx as a top level import in the client.
Also, let's add integration tests. I'd prefer those over unit tests in general.
Also, this fails against 3.9 because of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good! A few more items I noticed. Let me know if you want to discuss any
c32b2a9
to
5077808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
ENG-6011, ENG-6012, ENG-6013, ENG-6014, ENG-6039
With this PR we are already able to support the following snippet of code: