Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AvroAlias support added #636

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

vkorchik
Copy link
Contributor

@vkorchik vkorchik commented Dec 5, 2024

No description provided.

ayoub-benali
ayoub-benali previously approved these changes Jan 22, 2025
Copy link
Contributor

@ayoub-benali ayoub-benali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Any blocker @vlovgr ?

vlovgr
vlovgr previously approved these changes Jan 22, 2025
Copy link
Contributor

@vlovgr vlovgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@vkorchik
Copy link
Contributor Author

vkorchik commented Jan 22, 2025

@ayoub-benali @vlovgr Guys, thank you so much for your reviews!

ci/validate job failed due to headerCheck. It seems like headers should be updated with the 2025 year in multiple files, not just freshly added AvroAlias.scala:

- * Copyright 2019-2024 OVO Energy Limited
+ * Copyright 2019-2025 OVO Energy Limited

PS: oh, I fetched master and see that it was already fixed apart from my file :) Fixing!

@vkorchik vkorchik dismissed stale reviews from vlovgr and ayoub-benali via 54bc7b2 January 22, 2025 14:28
@ayoub-benali ayoub-benali merged commit bb175bb into fd4s:master Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants