Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Font Problem] Weird characters appear before emojis #127

Closed
karx1 opened this issue Aug 29, 2022 · 19 comments
Closed

[Font Problem] Weird characters appear before emojis #127

karx1 opened this issue Aug 29, 2022 · 19 comments

Comments

@karx1
Copy link

karx1 commented Aug 29, 2022

  • What does rofimoji show instead of the emojis? Can you please share a screenshot (`Alt+Shift+s** in rofimoji)

image

  • What do other apps like Firefox/Chrome/your text editor show instead of emojis?
    • Just the emoji, no square
  • Which emoji fonts do you have installed?
    • ttf-twemoji
  • Are the emoji fonts set in your font config?
    • No, but this used to work fine until the latest update
  • Which versions of rofimoji and pango are installed?
    • pango 1:1.50.9-1 and rofimoji 5.5.0-1 (Arch Linux)
@karx1
Copy link
Author

karx1 commented Aug 29, 2022

I'm running rofi 1.7.5-1 as well

@fdw
Copy link
Owner

fdw commented Aug 29, 2022

Could it be that your rofi theme uses icons? Or do you use a custom file?

@karx1
Copy link
Author

karx1 commented Aug 29, 2022 via email

@fdw
Copy link
Owner

fdw commented Aug 29, 2022

Thanks 🙂 Another idea: Which font do you use for text? And could you please paste your rofi configuration?

Also. which update broke it? rofimoji? Something else?

@karx1
Copy link
Author

karx1 commented Aug 29, 2022 via email

@fdw
Copy link
Owner

fdw commented Aug 29, 2022

Could you please add your rofi configuration and theme?

@karx1
Copy link
Author

karx1 commented Aug 29, 2022 via email

@fdw
Copy link
Owner

fdw commented Aug 29, 2022

Thanks. I've tried your theme, but it works fine for me. Also on latest rofi and rofimoji.

I'm grasping for straws, but what's your Python version?

@karx1
Copy link
Author

karx1 commented Aug 29, 2022

My python version is Python 3.10.6, and it was updated at the same time as rofi and rofimoji.

@karx1
Copy link
Author

karx1 commented Aug 29, 2022

So I downgraded rofi to 1.7.3-1, and now the squares don't show up. This seems to be an issue with rofi and not rofimoji.

Edit: With further testing, it seems that this bug showed up in rofi 1.7.4

@fdw
Copy link
Owner

fdw commented Aug 30, 2022

Thanks for that testing! I don't see what rofimoji could do differently to fix that.

Have you opened a bug against rofi?

@MosaicMan
Copy link

I was having the same issue in Arch Linux. For some reason, running it as a rofi mode does not show the weird squares before the emoji:

rofi -show emoji -modi emoji:/usr/bin/rofimoji

@alpheratz0
Copy link

Hi, I git bisect'd rofi and found that this behavior was introduced in the
following commit of rofi: davatorium/rofi@be6fe8ac.
It replaced the dot indicator with a checkbox (those weird characters) when
the -multi-select option of rofi-dmenu is passed, you cannot disable that
directly from rofimoji because it doesn't have an option to just pick a single
emoji and it always starts rofi-dmenu with the -multi-select option enabled.

@A-F-V
Copy link

A-F-V commented Sep 7, 2022

I was having the same issue in Arch Linux. For some reason, running it as a rofi mode does not show the weird squares before the emoji:

rofi -show emoji -modi emoji:/usr/bin/rofimoji

I observed similiar effect. However, (on my system) using that command no longer inserts the emoji into the application like running rofimoji does. Any ideas?

@fdw
Copy link
Owner

fdw commented Sep 8, 2022

Thanks for the work, @alpheratz0! That explains a lot.
I'd like to work on the issue, but I currently cannot reproduce it as my rofi is too old. Please be patient 🙂

However, (on my system) using that command no longer inserts the emoji into the application like running rofimoji does. Any ideas?

This is a known limitation of the script mode, sorry.

@alpheratz0
Copy link

Thanks for the work, @alpheratz0! That explains a lot. I'd like to work on the issue, but I currently cannot reproduce it as my rofi is too old. Please be patient slightly_smiling_face

It's not a big problem, I can wait 😆

Cheers!

fdw added a commit that referenced this issue Sep 13, 2022
This is a change in `rofi` 1.7.4 and looks ugly in `rofimoji`. To
circumvent this, we remove the empty checkboxes again and get something
similar to the previous look.

Thanks to @alpheratz0 for finding the problematic commit!

Issue: #127
@fdw
Copy link
Owner

fdw commented Sep 13, 2022

I've just pushed something that should help with this problem. Please try it and report back!
If it works, I'll push out a release in the next days.

@karx1
Copy link
Author

karx1 commented Sep 13, 2022

The new commit works for me on rofi 1.7.5, the squares no longer show up.

@fdw
Copy link
Owner

fdw commented Sep 17, 2022

Release is out 🙂

@fdw fdw closed this as completed Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants