-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
😈 is a devil #151
😈 is a devil #151
Conversation
Hey, thanks for the PR 🙂 Unfortunately, these files are automatically generated from the official Unicode documentation. So any changes here will be wiped the next time I update everything. |
Like this? |
Almost - the descriptions will be appended, so you don't need to repeat the original one. Just leave your new annotations, and it should work 🙂 |
@@ -0,0 +1 @@ | |||
😈 smiling face with horns <small>(demon, devil, imp)</small> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can also skip smiling face with horns <small>
, just leaving demon, devil, imp
.
Have you tried locally how it looks?
Hey, I'm sorry you closed this PR. Could I have done anything better? Do you want me to add your changes (with you as co-author, of course)? |
I expected this to be a trivial 1-minute fix and not to have to set up any infrastructure. It's fine, I just don't care enough. Do what you want. |
I see, thank you 🙂 Unfortunately, you were the first person to improve the descriptions with the new setup, so there was nothing to use as an example. I think I'll take your changes to make it easier for the next person. Thank you and have a good day 🙂 |
Issue: #151 Co-authored-by: Naïm Favier <[email protected]> Co-authored-by: Fabian Winter <[email protected]>
No description provided.