Add options to find query #14
Conversation
| where, order, | ||
| limit: filters.$limit, | ||
| offset: filters.$skip, | ||
| attributes: filters.$select || null | ||
| }; | ||
|
|
||
| }, params.sequelize); |
There was a problem hiding this comment.
👍 can we put this under $sequelize instead? That way it follows a similar pattern to the other special query params?
There was a problem hiding this comment.
I think that's ok. It's part of params not params.query (where we use that pattern to somewhat avoid property name clashes).
|
I'm cool with this. We should adds some docs around this as well. @feathersjs/core-team where do you want to put them? In the docs or leave something specific like this in the README? I'm inclined to put it in the docs so that it all stays together. Refs #12. |
|
Definitely in the docs repo. |
|
Ok then I'll create a corresponding issue in the |
|
Thanks guys. Let me know if I can be of any help. |
|
Thank you for contributing! I just published a patch release with your fix. |
|
You're far too kind. Thanks for your help. |
No description provided.