Tests and fixes #162
Tests and fixes #162
Conversation
…ections do not do clean up. In addition to that some of the individual tests only do clean up when it succeeds (In the .then callback). The result is that when a test fails it causes many other tests to fail and it can be difficult to see what is breaking. This change should alleviate some of that.
|
This looks great, thank you! I'll let @DesignByOnyx have a look and then we can get it out. |
|
This looks awesome. Thanks for taking the time to do this. I see no reason not to merge. For the sake of discussion, by introducing dialect-specific tests we have legitimized dialect-specific code. I was previously trying to avoid this, but I now see a lot of value in having optimizations for different engines. We should eventually start running the tests against all dialects so that we can catch any discrepancies quickly. I will create a separate issue to track that. Thanks for getting it started for us @ryanthegiantlion! |
|
@DesignByOnyx, @ryanthegiantlion already got you there. CI tests for SQLite, MySQL and Postgres have been added in #160 |
|
Released as v2.3.1 |
|
Ah, I missed that PR for the dialect-specific tests. My bad. |
Fixes for #125, #137 and #161
Also added tests for all the above.