This repository has been archived by the owner on Dec 17, 2018. It is now read-only.
Update ORM tests to ensure plain objects are returned #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DesignByOnyx I think you mean that we want to merge this one first. Correct? |
|
I think we'll merge this and bump it to version 0.10.0. I don't think the ORM tests were being used at all but since the signature has changed it will be better. Plus then greenkeeper will keep us honest. |
|
Yes, this should be merged first. Then the sequelize and mongoose PRs referenced above should start passing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This closes #38
ORM objects should return plain javascript objects be default. There are changes in both feathers-mongoose and feathers-sequelize which should be merged
beforeafter this is merged. Please reach out to me if you have any questions.