Update all methods to return plain JS objects #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates all service methods to return plain javascript objects by default (
{ raw: true }
). This is a breaking change (see below for an easy fix).This ensures that feathers-sequelize will play nicely and consistently with common hooks and other 3rd party hooks and integrations. Users can pass
{ raw: false }
to any of the service methods and get ORM-wrapped objects if they so choose. There are tests covering this new functionality located in this PR in feathers-service-hooks.This PR also includes hooks so users can easily
hydrate
hook results into ORM objects and converselydehydrate
those objects back into plain javascript objects.The conversation around this issue is spread out across multiple issues in multiple repositories. This is my best attempt to aggregate this conversion:
#18
#19
#24
feathersjs-ecosystem/feathers-hooks-common#144
feathersjs-ecosystem/feathers-hooks-common#146
feathersjs-ecosystem/feathers-hooks-common#150