Merge pull request #30 from feathersjs/fix-async-hook

hashPassword: Async bcrypt usage needs a promise
feathersjs · Aug 29, 2018 · b854980 · b854980
1 parent fff3572
commit b854980
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/packages/authentication/src/hooks/hash-password.js b/packages/authentication/src/hooks/hash-password.js
@@ -7,13 +7,16 @@ import bcrypt from 'bcrypt';
  */
 exports.hashPassword = function(passwordField = 'password'){
   return function(hook) {
-    bcrypt.genSalt(10, function(err, salt) {
-      bcrypt.hash(hook.data[passwordField], salt, function(err, hash) {
-        if (err) {
-          throw new Error(err);
-        } else {
-          hook.data[passwordField] = hash;
-        }
+    return new Promise(function(resolve, reject){
+      bcrypt.genSalt(10, function(err, salt) {
+        bcrypt.hash(hook.data[passwordField], salt, function(err, hash) {
+          if (err) {
+            reject(err);
+          } else {
+            hook.data[passwordField] = hash;
+            resolve(hook);
+          }
+        });
       });
     });
   };