Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument normalization runs before event mixin punched methods #150

Closed
daffl opened this issue Oct 21, 2015 · 1 comment
Closed

Argument normalization runs before event mixin punched methods #150

daffl opened this issue Oct 21, 2015 · 1 comment

Comments

@daffl
Copy link
Member

daffl commented Oct 21, 2015

The reason is that the event mixins get initialized in setup (see https://github.com/feathersjs/feathers/blob/master/lib/mixins/event.js#L19) after the normalizer ran. I can't remember if there was a reason why this is running when overwriting setup instead of setting it up right away.

This causes an error when calling service methods on the server without a callback (because Rubberduck expects the last argument to be a callback) as described in feathersjs-ecosystem/feathers-memory#8.

@lock
Copy link

lock bot commented Feb 8, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant