HTTP status codes

[ahdinosaur]

hi,

how does one send an HTTP status code other than 200, either on success or on error? i'm trying to follow HTTP API best practices, something similar to this.

cheers!

[ahdinosaur]

ah, now i see #38 for errors. is there a way to send non-error custom status codes?

[ahdinosaur]

this may be something better handled by feathers as it is specific to RESTful HTTP. specifically i was thinking about 201 status and Location header on create and 204 status when response is empty. is this appropriate?

[daffl]

This would be a good thing to add. Always looking for more ways to improve the REST provider. Although, you should be able to implement this functionality already using a custom middleware (req.data is the data returned by your service):

var app = feathers()
  .use('/todos', todoService)
  .use(function(req, res, next) {
    if(_.isEmpty(req.data)) {
      res.status = 204;
    }

    if(req.method === 'POST') {
      res.status = 201;
    }

    next();
  });

app.listen(8080);

[ahdinosaur]

ah, awesome, thank you.

[daffl]

I'm wondering if it should still send a 204 when the response is {} is an empty object equals to an empty response? Besides that we could easily add those status codes to the REST handler.

[jgillich]

IMHO an empty object is still a response (just like an empty array). I would consider null to be an empty response.

[ahdinosaur]

i agreed with @jgillich.

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.