Fix 404 not being properly thrown by REST provider #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way the routes are created by the REST provider prevent 404 error being properly thrown. To reproduce, just run the feathers todo-list demo and browse to an URL like `/todos/foo/bar`, it won’t return a 404 as it should but a 200 without any content (because of the `app.use(uri, handler);` statement catching any URLs starting with `/todos`)
|
That makes sense, thank you! I will release a 1.1.1 with this fix later today. |
daffl
added a commit
that referenced
this pull request
Sep 22, 2015
Fix 404 not being properly thrown by REST provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the routes are created by the REST provider prevent 404 errors being properly thrown.
To reproduce, just run the feathers todo-list demo and browse to an URL like
/todos/foo/bar, it won’t return a 404 as it should but a 200 without any content (because of theapp.use(uri, handler);statement catching any URLs starting with/todos)