-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event filtering and params extension for Primus #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 6, 2014
Merged
… common Socket functionality.
daffl
added a commit
that referenced
this pull request
Apr 8, 2014
Event filtering and params extension for Primus
daffl
pushed a commit
that referenced
this pull request
Aug 19, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 21, 2018
daffl
added a commit
that referenced
this pull request
Aug 21, 2018
* Rename repository and use npm scope * Update Codeclimate token
daffl
added a commit
that referenced
this pull request
Aug 22, 2018
* Rename repository and use npm scope * Update Codeclimate token
daffl
added a commit
that referenced
this pull request
Aug 23, 2018
* Update to new plugin infrastructure and npm scopes * Update Codeclimate token
daffl
pushed a commit
that referenced
this pull request
Aug 28, 2018
daffl
added a commit
that referenced
this pull request
Aug 28, 2018
daffl
added a commit
that referenced
this pull request
Aug 29, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
daffl
added a commit
that referenced
this pull request
Aug 29, 2018
daffl
added a commit
that referenced
this pull request
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements #50 for Primus and extracts common Socket provider functionality (setting up event handlers and methods). Closes #32 and finishes the support for event filtering and extended service parameters.