Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove app.lookup and make the functionality available as app.service #94

Merged
merged 1 commit into from
Sep 10, 2014

Conversation

daffl
Copy link
Member

@daffl daffl commented Sep 9, 2014

It turned out that app.lookup is somewhat redundant and not very descriptive. Instead I think it is a lot more explicit to make service lookup available as app.service(path):

app.service('todos').create({ text: 'Do something!' }, {}, function(error, data) {
  console.log('Created Todo', data);
});

To maintain backwards compatibility simply assign app.service as app.lookup like so:

app.configure(function() {
  this.lookup = this.service;
});

@daffl daffl added this to the 1.0.0 milestone Sep 9, 2014
@daffl
Copy link
Member Author

daffl commented Sep 9, 2014

Also upgrades SocketIO to 1.1.0.

daffl added a commit that referenced this pull request Sep 10, 2014
Remove app.lookup and make the functionality available as app.service
@daffl daffl merged commit 5474b92 into master Sep 10, 2014
@daffl daffl deleted the remove-lookup branch September 10, 2014 15:33
daffl pushed a commit that referenced this pull request Aug 21, 2018
* Allow mixture of options for custom error handling

* Update the README to include info on the error handler
daffl pushed a commit that referenced this pull request Aug 21, 2018
* Allow mixture of options for custom error handling

* Update the README to include info on the error handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant