Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to pass in options to the Select.From method #106

Closed
wants to merge 1 commit into from

Conversation

SethDobson
Copy link

If there is a better or different way you would like me to approach this
then let me know.

If there is a better or different way you would like me to approach this
then let me know.
@adiel
Copy link
Member

adiel commented Sep 9, 2014

Hi, thanks for this. I think what you after is the same change requested in #92 - which no one else has tackled yet - that is, to be able to specify different options when finding the select element from when finding the option within the element.

when you do

browserSession.Select("Audi",myOptions).From("Manufacturer");

right now, myOptions are used for both of these searches.

Looks to me like your change:

browserSession.Select("Audi",selectOptions).From("Manufacturer", fromOptions);

will mean the selectOptions are ignored and the fromOptions are used in both searches - not the intention I'm sure.

What we need to do is pass both these options from the SelectFrom.cs line 37 into the new Coypu.Actions.Select - and in there use the appropriate one for each of the two searches.

Wanna have a go at that? Would be great if you could try and write a test at some level for this change too. An acceptance test might be clearest and easiest in this case to make the intention clear.

Cheers!

@SethDobson
Copy link
Author

Thanks for the info. I'll work on this in my free time. We just started using Coypu where I work so you will likely hear more and more from me. This is a great tool and I look forward to making it better and better. FYI It would be nice to have some way to interact with javascript popups without using exec script.

@SethDobson SethDobson closed this Sep 10, 2014
@adiel
Copy link
Member

adiel commented Sep 10, 2014

Coypu's pretty good at handling popups. If you post your question, i.e. exactly what you need to do, on the google group or stack overflow I'll point you in the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants