Update Selenium to v4 + .NET 6 Tests #225

slang25 · 2021-11-06T18:07:41Z

This PR contains 3 changes:

Updating the Selenium.WebDriver dependency to 4.0.1
Changes test projects to .NET 6
Get the test passing on macOS, this includes changing the self-hosted server to aspnetcore

petersladek · 2021-11-25T12:56:47Z

@obstar Any plans when this will be merged?

mhlavacek · 2022-03-04T20:16:48Z

Any updates on this? I'm waiting to be able to update to selenium webdriver 4.x

slang25 · 2022-03-04T20:40:06Z

That'll be a question for @obstar, would be good to know if there is an intention to merge. No pressure here, just nice to have from my perspective

sbowler · 2022-03-08T00:44:42Z

I'm pretty sure there's a runtime issue taking screenshots that needs to be adjusted with this move to .NET 6. See SeleniumHQ/selenium#8760 for more details on what I'm running into and possible solutions. I could be wrong, but I think this should be adjusted here.

ben-soler · 2022-04-07T08:55:35Z

Any updates on this PR?

DDSGooch · 2022-07-13T09:58:31Z

When will this be merged? Is there any reason this can't be done now. We'd really appreciate this update and I'm happy to do some testing on this. If it's just the screenshot issue only supporting PNGs, that's not a showstopper for us. Thanks

adiel · 2023-03-28T13:15:13Z

Hi! Just checking back in on this project and seems like nobody is maintaining it any more.

Any volunteers from this thread? I know a lot of projects are relying on it still.

sbowler

I would also suggest updating the NUnit project to net6.0 instead of net45. At this point it would probably be good to update some of the other dependencies as well like browser drivers for example.

sbowler · 2023-05-24T19:45:33Z

src/Coypu.Drivers.Tests/DriverSpecs.cs

 using ElementFinder = Coypu.Finders.ElementFinder;
 using FrameFinder = Coypu.Finders.FrameFinder;

 [SetUpFixture]
 public class AssemblyTearDown
 {
-    public static SelfishSite TestSite;
+    public static SelfHostedSite TestSite;


You are not including the namespace for this.

The namespace is Coypu.Drivers.Tests.Sites which is included on line 6, it also compiles etc... What IDE are you viewing it with? Could be an IDE specific quirk? (in which case I'm happy to try and tweak this to workaround it)

I was using visual studio 2022. That's where the old type was defined, you moved it to the Acceptance tests, see https://github.com/featurist/coypu/pull/225/files#diff-9e9da1c47aac76e44f6605c2eee71162d1ab18ad7995388b3b301c694fccfdefR10

sbowler · 2023-05-24T19:46:09Z

src/Coypu.Drivers.Tests/DriverSpecs.cs

-        {
-            return "file:///" + Path.Combine(TestContext.CurrentContext.TestDirectory, $@"html\{page}")
-                                    .Replace("\\", "/");
+            Driver.Visit(PathHelper.GetPageHtmlPath(TestPage), Root);


PathHelper is not included and is also not public so it can't be referenced here. Maybe consider moving the PathHelper class or make it public.

sbowler · 2023-06-01T16:07:14Z

@slang25 I think I've highlighted the main issues I found. Just wondering if you'll be able to update this and an idea on the timeframe?

ijabit · 2023-06-01T16:31:19Z

Same question as @sbowler can this PR be merged? I hate to have to use the older Selenium version.
Is this project dead? Is there an alternative?

slang25 · 2023-06-01T16:35:35Z

I'll have a look over the weekend, you are right, it's totally broken, I blame past me 😆

obstar · 2023-06-01T21:32:55Z

@ijabit tbh the best alternative is playwright a lot faster and user friendly than selenium 🤷‍♂️

ijabit · 2023-06-01T21:35:22Z

Thanks! I think I'm locked in to Selenium though due to organizational choices

adiel · 2023-06-01T21:36:08Z

For sure. Although a Coypu driver for Playwright should be pretty trivial and best of both worlds if you ask me. It still has all the semantic finder and wait issues that this project tackles. I'm planning to do this in a few weeks time when I have some time off coming up.

…

On Thu, 1 Jun 2023 at 22:33, Jakub Obstarczyk ***@***.***> wrote: @ijabit <https://github.com/ijabit> tbh the best alternative is playwright a lot faster and user friendly than selenium 🤷‍♂️ — Reply to this email directly, view it on GitHub <#225 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASTJECT63T2M55CTJWLUTXJEDBHANCNFSM5HP3FOPQ> . You are receiving this because you commented.Message ID: ***@***.***>

ijabit · 2023-06-06T22:35:38Z

I thought Coypu was tied to Selenium, interesting that you might be able to hook it up to Playwright

sbowler · 2023-06-19T16:10:27Z

@slang25 If you don't have time to work on this, let me know and I can finish it up and submit a PR if you need.

slang25 · 2023-06-19T16:29:34Z

I'm not sure I'm going to get around to it 😔

adiel · 2023-06-19T16:36:15Z

I did get this branch working the other day - it was basically just the errors that were pointed out on the pull request. Then I had to update a bunch of references and language settings - I didn't really know what I was doing not having run dotnet for so many years. Managed to get it compiling though on my Mac, and installed Playwright ok and made the first steps towards a Playwright driver. Hoping to get time to finish it in a couple of weeks time. I'll push what I did (minus the playwright stuff) later when I get in and maybe you can give it a run and see if I did anything stupid Stacy?

…

On Mon, 19 Jun 2023 at 17:29, Stuart Lang ***@***.***> wrote: I'm not sure I'm going to get around to it 😔 — Reply to this email directly, view it on GitHub <#225 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASTJB7PICFBCFOLB2A4CTXMB47VANCNFSM5HP3FOPQ> . You are receiving this because you commented.Message ID: ***@***.***>

ijabit · 2023-06-30T18:01:05Z

Any updates on this one?

sbowler · 2023-07-05T18:19:19Z

Closing in favor of #228

adiel · 2023-12-09T16:24:38Z

I thought Coypu was tied to Selenium, interesting that you might be able to hook it up to Playwright

#231

slang25 added 4 commits November 6, 2021 17:58

Update Selenium to v4

ebf9bb5

Add inconclusive message for non-windows test runs

5150505

Use random port for self-hosted web server

3258c3b

Use PathHelper

245f82e

slang25 changed the title ~~Update Selenium to v4~~ Update Selenium to v4 + .NET 6 Tests Nov 7, 2021

sbowler mentioned this pull request Jan 28, 2022

Selenium 4 and .NET 6 #222

Closed

adiel mentioned this pull request May 4, 2023

Maintainer #227

Closed

sbowler requested changes May 24, 2023

View reviewed changes

sbowler mentioned this pull request May 24, 2023

Updated selenium to selenium 4 #226

Closed

adiel mentioned this pull request Jun 20, 2023

Upgrade c#, selenium, get working on macOS #228

Merged

sbowler closed this Jul 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Selenium to v4 + .NET 6 Tests #225

Update Selenium to v4 + .NET 6 Tests #225

slang25 commented Nov 6, 2021

petersladek commented Nov 25, 2021

mhlavacek commented Mar 4, 2022

slang25 commented Mar 4, 2022

sbowler commented Mar 8, 2022

ben-soler commented Apr 7, 2022

DDSGooch commented Jul 13, 2022 •

edited

Loading

adiel commented Mar 28, 2023 •

edited

Loading

sbowler left a comment

sbowler May 24, 2023

slang25 May 25, 2023

sbowler May 25, 2023 •

edited

Loading

sbowler May 24, 2023

sbowler commented Jun 1, 2023

ijabit commented Jun 1, 2023

slang25 commented Jun 1, 2023

obstar commented Jun 1, 2023

ijabit commented Jun 1, 2023

adiel commented Jun 1, 2023 via email

ijabit commented Jun 6, 2023

sbowler commented Jun 19, 2023

slang25 commented Jun 19, 2023

adiel commented Jun 19, 2023 via email

ijabit commented Jun 30, 2023

sbowler commented Jul 5, 2023

adiel commented Dec 9, 2023

Update Selenium to v4 + .NET 6 Tests #225

Update Selenium to v4 + .NET 6 Tests #225

Conversation

slang25 commented Nov 6, 2021

petersladek commented Nov 25, 2021

mhlavacek commented Mar 4, 2022

slang25 commented Mar 4, 2022

sbowler commented Mar 8, 2022

ben-soler commented Apr 7, 2022

DDSGooch commented Jul 13, 2022 • edited Loading

adiel commented Mar 28, 2023 • edited Loading

sbowler left a comment

Choose a reason for hiding this comment

sbowler May 24, 2023

Choose a reason for hiding this comment

slang25 May 25, 2023

Choose a reason for hiding this comment

sbowler May 25, 2023 • edited Loading

Choose a reason for hiding this comment

sbowler May 24, 2023

Choose a reason for hiding this comment

sbowler commented Jun 1, 2023

ijabit commented Jun 1, 2023

slang25 commented Jun 1, 2023

obstar commented Jun 1, 2023

ijabit commented Jun 1, 2023

adiel commented Jun 1, 2023 via email

ijabit commented Jun 6, 2023

sbowler commented Jun 19, 2023

slang25 commented Jun 19, 2023

adiel commented Jun 19, 2023 via email

ijabit commented Jun 30, 2023

sbowler commented Jul 5, 2023

adiel commented Dec 9, 2023

DDSGooch commented Jul 13, 2022 •

edited

Loading

adiel commented Mar 28, 2023 •

edited

Loading

sbowler May 25, 2023 •

edited

Loading