Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Laravel 10 #303

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Added support for Laravel 10 #303

merged 3 commits into from
Feb 23, 2023

Conversation

Vincent-dejong
Copy link

No description provided.

@rolfdenhartog
Copy link

rolfdenhartog commented Feb 17, 2023 •
edited
Loading

Nice! I think the matrix in .github/workflows/main.yml should also be updated containing PHP 8.2.

https://github.com/fedeisas/laravel-mail-css-inliner/blob/6f98d7425e2c95032beae2885f3ca104079ab482/.github/workflows/main.yml

@fabiofdsantos
Copy link

ping @DannyvdSluijs

DannyvdSluijs
DannyvdSluijs reviewed Feb 21, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@fedeisas fedeisas mentioned this pull request Feb 21, 2023
Merged
@DannyvdSluijs
Copy link
Collaborator

In addition there is some feedback in the pipeline see https://github.com/fedeisas/laravel-mail-css-inliner/actions/runs/4182613296/jobs/7356352244

@TSchuermans
Copy link

@DannyvdSluijs doesn't that mean there has to be a space surrounding the || in the version constraint?

@driftingly
Copy link

@DannyvdSluijs doesn't that mean there has to be a space surrounding the || in the version constraint?

@TSchuermans @Vincent-dejong Looks that way to me

DannyvdSluijs
DannyvdSluijs reviewed Feb 23, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@DannyvdSluijs
Copy link
Collaborator

Trying with the spaces as that looks like the logical change based on the feedback from the action.

@DannyvdSluijs DannyvdSluijs merged commit 90eb787 into fedeisas:master Feb 23, 2023
@Vincent-dejong
Copy link
Author

Thanks everyone! I'm on holiday so I missed the feedback but cool to see it's now merged.

@kirkbushell
Copy link

It's not actually working on Laravel 10. Was this tested?

@DannyvdSluijs
Copy link
Collaborator

DannyvdSluijs commented Sep 12, 2023 •
edited
Loading

@kirkbushell

I can't recall completely, but I would assume so. If you can share a repo, gist or just bits of code to reproduce we can take it from there. Feel free to open a new issue for this. As a closed Pull Request might not get the attention this deserves.

Since this kind of was like a bee-sting and I couldn't resist to scratch I've made a very small proof of concept using:

  • Laravel 10.22
  • Laravel Mail CSS Inliner 5.2

You can "send" an email to the logs using php artisan app:send-email and you can review the logs for the result. Where you'll find something like:

[2023-09-12 07:34:10] production.DEBUG: From: Example <[email protected]>
To: [email protected]
Subject: Test Email
MIME-Version: 1.0
Date: Tue, 12 Sep 2023 07:34:10 +0000
Message-ID: <[email protected]>
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html>
<head>
    
</head>
<body>
<h1 style="font-size: 24px; color: #000;">Hey you</h1>
</body>
</html>

You can see the source html and css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DannyvdSluijs DannyvdSluijs DannyvdSluijs left review comments

@ABartelt ABartelt ABartelt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Vincent-dejong @rolfdenhartog @fabiofdsantos @DannyvdSluijs @TSchuermans @driftingly @kirkbushell @ABartelt