Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 7 compatibility #72

Merged
merged 5 commits into from
Apr 4, 2020
Merged

Laravel 7 compatibility #72

merged 5 commits into from
Apr 4, 2020

Conversation

zupolgec
Copy link
Contributor

See issue #70

@zupolgec
Copy link
Contributor Author

Breaks backward compatibility with Laravel 5 and 6

@zupolgec zupolgec mentioned this pull request Mar 12, 2020
@vesper8
Copy link

vesper8 commented Mar 12, 2020

@zupolgec if the changes made in src/LaravelMailCssInlinerServiceProvider.php only work on Laravel 7, then the composer.json should now only support ^7.0 in a new tagged release? By adding ^5.0|^6.0|^7.0 won't that cause problems with people who don't have L7?

@zupolgec
Copy link
Contributor Author

@vesper8 yep, you're right! thanks 😉

@vesper8
Copy link

vesper8 commented Mar 23, 2020

possible to merge this one pretty please @fedeisas ?

@jdavidbakr
Copy link

@zupolgec - maybe update the travis.yml to exclude the irrelevant versions of PHP to at least get Travis happy

@duxthefux
Copy link

would be really cool to merge this soon

@jdavidbakr
Copy link

Any chance we can get an update on when this might get merged it? This is the only package that is preventing me from upgrading my projects to Laravel 7.

@djereg
Copy link

djereg commented Apr 4, 2020

@jdavidbakr metoo :)

@fedeisas I'm looking forward to get notification about new release.

@zupolgec
Copy link
Contributor Author

zupolgec commented Apr 4, 2020

@jdavidbakr @djereg you can use my repository for the time being. See #70 (comment)

@fedeisas fedeisas merged commit 9a3b18a into fedeisas:master Apr 4, 2020
@fedeisas fedeisas mentioned this pull request Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants