This repository has been archived by the owner on Sep 11, 2021. It is now read-only.
Ensure consistent return type from setEnvironment #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobq
reviewed
Apr 19, 2019
| @@ -45,7 +45,8 @@ export function setEnvironment(env: InstallationDetails) { | |||
| log(chalk.bold.green(`Now configuring the Visual Studio Build Tools..`)); | |||
| } else { | |||
| log(chalk.bold.green(`Skipping configuration: No configuration for Python or Visual Studio Build Tools required.`)); | |||
| return; | |||
| return(new Promise((resolve, reject) => resolve())) | |||
There was a problem hiding this comment.
Why not Promise.resolve()?
|
Aha! I didn't notice that sneaky extra |
|
This looks solid to me, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In setEnvironment(), a different type is returned if you are skipping configuration instead of invoking the executeChildProcess. When the caller attempts to chain off the result you get the following type error:
TypeError: Cannot read property 'then' of undefined
This is the caller code snippet invoking setEnvironment:
setEnvironment(variables).then(() => process.exit(0)).catch(() =>process.exit(1));`TypeError: Cannot read property 'then' of undefined
at install_1.install (C:\Users\Dave\AppData\Roaming\npm\node_modules\windows-build-tools\dist\start.js:19:17)
Should fix #175 win10 ver17763.316 Could not install Visual Studio Build Tools.