-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh Timeseries Output #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a question about the testing of the dataset creation but I dont think its a big deal.
Just one comment on the mentioned topic of saving DataArrays to disc. I recently ran into this issue dealing with large raster datasets and was able to get by using rioxarray: https://corteva.github.io/rioxarray/html/rioxarray.html#rioxarray.raster_dataset.RasterDataset.to_raster. Using the windowed parameter of the .to_raster() method writes the xarray DataArray to disc in the same size as it was chunked when first being read. |
Gotcha. I've used rioxarray as well. Since this isn't raster data I think we have to write out to Zarr or another format. I hope that Xvec continues to be developed since their data model seems like it would be ideal for our use case (i.e., vector GIS data with multidimensional values) |
Codecov ReportAttention: Patch coverage is
|
Notes
plan_hdf.mesh_timeseries_output("MeshName", "Water Surface")
plan_hdf.mesh_timeseries_output_cells("MeshName")
,plan_hdf.mesh_timeseries_output_faces("MeshName")
dask
is installed, DataArray/Dataset objects are based on Dask arrays. If not, default to numpy arrays.rashdf
will set the dask array chunk size to match the HDF chunk size. I don't know if it's optimal to let the user set the dask array chunk size upfront.Examples
Read cell water surface output as DataArray
Read all available cell-based timeseries output as DataArray
Read all available mesh face timeseries outputs as Dataset