Skip to content

Commit

Permalink
[CALCITE-4841] Support decimal column type in CSV file format
Browse files Browse the repository at this point in the history
- Introduce a new `decimal` type in the CSV file format for
  more accurate representation of decimal data.
- Implement the `decimal` SQL type using the BigDecimal JAVA type.
  • Loading branch information
xwkuang5 authored and jacques-n committed Nov 18, 2021
1 parent faee09f commit 065e323
Show file tree
Hide file tree
Showing 11 changed files with 269 additions and 128 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@

import org.apache.calcite.DataContext;
import org.apache.calcite.adapter.file.CsvEnumerator;
import org.apache.calcite.adapter.file.CsvFieldType;
import org.apache.calcite.adapter.java.JavaTypeFactory;
import org.apache.calcite.linq4j.AbstractEnumerable;
import org.apache.calcite.linq4j.Enumerable;
import org.apache.calcite.linq4j.Enumerator;
import org.apache.calcite.rel.type.RelDataType;
import org.apache.calcite.rel.type.RelProtoDataType;
import org.apache.calcite.rex.RexCall;
import org.apache.calcite.rex.RexInputRef;
Expand Down Expand Up @@ -57,7 +57,7 @@ public CsvFilterableTable(Source source, RelProtoDataType protoRowType) {

@Override public Enumerable<@Nullable Object[]> scan(DataContext root, List<RexNode> filters) {
JavaTypeFactory typeFactory = root.getTypeFactory();
final List<CsvFieldType> fieldTypes = getFieldTypes(typeFactory);
final List<RelDataType> fieldTypes = getFieldTypes(typeFactory);
final @Nullable String[] filterValues = new String[fieldTypes.size()];
filters.removeIf(filter -> addFilter(filter, filterValues));
final List<Integer> fields = ImmutableIntList.identity(fieldTypes.size());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@

import org.apache.calcite.DataContext;
import org.apache.calcite.adapter.file.CsvEnumerator;
import org.apache.calcite.adapter.file.CsvFieldType;
import org.apache.calcite.adapter.java.JavaTypeFactory;
import org.apache.calcite.linq4j.AbstractEnumerable;
import org.apache.calcite.linq4j.Enumerable;
import org.apache.calcite.linq4j.Enumerator;
import org.apache.calcite.rel.type.RelDataType;
import org.apache.calcite.rel.type.RelProtoDataType;
import org.apache.calcite.schema.ScannableTable;
import org.apache.calcite.util.ImmutableIntList;
Expand Down Expand Up @@ -52,7 +52,7 @@ public class CsvScannableTable extends CsvTable

@Override public Enumerable<@Nullable Object[]> scan(DataContext root) {
JavaTypeFactory typeFactory = root.getTypeFactory();
final List<CsvFieldType> fieldTypes = getFieldTypes(typeFactory);
final List<RelDataType> fieldTypes = getFieldTypes(typeFactory);
final List<Integer> fields = ImmutableIntList.identity(fieldTypes.size());
final AtomicBoolean cancelFlag = DataContext.Variable.CANCEL_FLAG.get(root);
return new AbstractEnumerable<@Nullable Object[]>() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@

import org.apache.calcite.DataContext;
import org.apache.calcite.adapter.file.CsvEnumerator;
import org.apache.calcite.adapter.file.CsvFieldType;
import org.apache.calcite.adapter.java.JavaTypeFactory;
import org.apache.calcite.linq4j.AbstractEnumerable;
import org.apache.calcite.linq4j.Enumerable;
import org.apache.calcite.linq4j.Enumerator;
import org.apache.calcite.rel.type.RelDataType;
import org.apache.calcite.rel.type.RelProtoDataType;
import org.apache.calcite.schema.ScannableTable;
import org.apache.calcite.schema.StreamableTable;
Expand Down Expand Up @@ -58,7 +58,7 @@ public class CsvStreamScannableTable extends CsvScannableTable

@Override public Enumerable<@Nullable Object[]> scan(DataContext root) {
JavaTypeFactory typeFactory = root.getTypeFactory();
final List<CsvFieldType> fieldTypes = getFieldTypes(typeFactory);
final List<RelDataType> fieldTypes = getFieldTypes(typeFactory);
final List<Integer> fields = ImmutableIntList.identity(fieldTypes.size());
final AtomicBoolean cancelFlag = DataContext.Variable.CANCEL_FLAG.get(root);
return new AbstractEnumerable<@Nullable Object[]>() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
package org.apache.calcite.adapter.csv;

import org.apache.calcite.adapter.file.CsvEnumerator;
import org.apache.calcite.adapter.file.CsvFieldType;
import org.apache.calcite.adapter.java.JavaTypeFactory;
import org.apache.calcite.rel.type.RelDataType;
import org.apache.calcite.rel.type.RelDataTypeFactory;
Expand All @@ -37,7 +36,7 @@ public abstract class CsvTable extends AbstractTable {
protected final Source source;
protected final @Nullable RelProtoDataType protoRowType;
private @Nullable RelDataType rowType;
private @Nullable List<CsvFieldType> fieldTypes;
private @Nullable List<RelDataType> fieldTypes;

/** Creates a CsvTable. */
CsvTable(Source source, @Nullable RelProtoDataType protoRowType) {
Expand All @@ -57,7 +56,7 @@ public abstract class CsvTable extends AbstractTable {
}

/** Returns the field types of this CSV table. */
public List<CsvFieldType> getFieldTypes(RelDataTypeFactory typeFactory) {
public List<RelDataType> getFieldTypes(RelDataTypeFactory typeFactory) {
if (fieldTypes == null) {
fieldTypes = new ArrayList<>();
CsvEnumerator.deduceRowType((JavaTypeFactory) typeFactory, source,
Expand Down
Loading

0 comments on commit 065e323

Please sign in to comment.