upgrade docker image, fix readme, remove deprecated gem-install flags #1984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
gem install
options--no-ri
&--no-rdoc
that cause installation to failpnpm build
in DockerfileMotivation and Context
Main importance are the Dockerfile baseimage upgrade as currently used image is no longer available. This in turn pulls in newer ruby/gem which causes
gem install
statements to fail due to abovementioned deprecated options.Basically this change re-enables the ability to build ferdium via provided Dockerfile.
Checklist
pnpm prepare-code
)pnpm test
passesRelease Notes
none