Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade docker image, fix readme, remove deprecated gem-install flags #1984

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

laur89
Copy link
Contributor

@laur89 laur89 commented Nov 28, 2024

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

  • update references to Ferdium 6 -> 7 throughout the documentation/code
  • upgrade Dockerfile baseimage to Bookworm (current Debian stable)
  • remove deprecated gem install options --no-ri & --no-rdoc that cause installation to fail
  • add architecture detection to pnpm build in Dockerfile

Motivation and Context

Main importance are the Dockerfile baseimage upgrade as currently used image is no longer available. This in turn pulls in newer ruby/gem which causes gem install statements to fail due to abovementioned deprecated options.

Basically this change re-enables the ability to build ferdium via provided Dockerfile.

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

none

@laur89 laur89 closed this Nov 28, 2024
@laur89 laur89 deleted the cleanup branch November 28, 2024 23:26
@laur89 laur89 restored the cleanup branch November 28, 2024 23:27
@laur89 laur89 reopened this Nov 28, 2024
@vraravam vraravam merged commit f79fae9 into ferdium:develop Nov 29, 2024
5 checks passed
@vraravam
Copy link
Contributor

@all-contributors please add @laur89 for code

Copy link
Contributor

@vraravam

I've put up a pull request to add @laur89! 🎉

@laur89 laur89 deleted the cleanup branch November 29, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants