Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/update last changes to make hardware-wallet tests working. #108

Open
isaacvr opened this issue Oct 31, 2019 · 0 comments
Open

Refactor/update last changes to make hardware-wallet tests working. #108

isaacvr opened this issue Oct 31, 2019 · 0 comments

Comments

@isaacvr
Copy link

isaacvr commented Oct 31, 2019

Feature description

Refactor tests

Is your feature request related to a problem? Please describe.
Hardware-wallet tests are not working.

Describe the solution you'd like
Just move the remaining tests to a TODO issue.

Additional context
https://github.com/skycoin/hardware-wallet/issues/84
stdevMac pushed a commit that referenced this issue Nov 11, 2019
move out of common some no available function in hw for libskycoin_as…
2f3328d 
…sert ref #108
stdevMac pushed a commit that referenced this issue Nov 11, 2019
move TestSumSHA256 out of hw tests ref #108
94769a3
stdevMac pushed a commit that referenced this issue Nov 11, 2019
fix some function signatures from libskycoin.h ref #108
c9e12bb
stdevMac pushed a commit that referenced this issue Nov 11, 2019
Merge remote-tracking branch 'simelo/stdevHan_t105_update_submodule_0…
ca974af 
….27.0' into stdevAlDen_t108_refactor_libskycoin_assert

Conflicts:
	lib/cgo/tests/testutils/libsky_assert.common.c
ref #108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@isaacvr