Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fip-0001 and initialize the repo #1
Add fip-0001 and initialize the repo #1
Changes from all commits
0556cca
a445b20
4480f1e
52e37e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that although discussions can take place in multiple places, there is a single source of truth for decision-making. Someone who wants to follow history of discussion should be able to find it in one place. I think this should be highlighted. The most convenient place in this case seems to be GH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix inconsistent use of FIP-1 vs. FIP 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should really have a small philosophy section somewhere, this will help a lot down the road when deciding how to change and expand Filecoin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead of having a philosophy section, which is nice, but less directly actionable, we should have a 'Filecoin Project Goals' section, that details what Filecoin is trying to accomplish.
I think this should be an expanded version of the Filecoin mission statement. I'll sketch up a draft of that today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. I think it would be really helpful to have a documented set of "principles" of operation, as more actionable than philosophy. These would represent "how" to complement the mission's "what".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whyrusleeping do you have the expanded version of the Filecoin mission statement? Can you point me to the most complete version available?
@anorth looks like @momack2 started a principles doc here, will iterate based on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anorth @whyrusleeping - I'm working on this here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document is still lacking in how decisions are made and what makes an FIP "accepted". There are many constraints and entities in Filecoin. I would expect a checklist of constraints with reviews (e.g. security, implementation complexity, incentive, etc) and a checklist of different entities interests (e.g. storage clients, current miners large and small, future miners large and small, application developers, protocol researchers, ecosystem partners, token holders, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there are two parts to the FIP process:
xyz
, instead ofzyx
as in today's protocol, because..".Both of these will come as PRs. The first one in this repository and the second one in the code repository(ies) that the proposal touches.
The text above touches step 1) only, but any subsequent PRs that work on the implementation should be linked to the FIP PR, e.g., through a codename/FIP number. I think it would be useful to clarify this and also indicate when implementation should start (e.g., only after the FIP gets the "Final" stamp).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get the Final stamp the FIP must be implemented by 2 clients - so FIPs should be implemented when Accepted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mirrors security section added to the EIP process in Dec 19.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Numbering FIPs by the PR number only will be confusing IMO. I would be in favour of having a sequence number instead, or in addition. For example, a convention of
FIP-2.1321
could stand for the second FIP in history, proposed in PR #1321.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find that hard to believe/implement when the FIP editors are also key core developers. Is it even possible to have a substantive discussion around the merit and feasibility of a FIP without Dig and Why offering their opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust to revised EIP naming conventions (EIP-1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix inconsistent use of FIP-1 vs. FIP 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a pretty arbitrary selection of links. I'm not sure the whole bibliography section adds value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text matches URLs