Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run deal filter for offline deals #1067

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Conversation

LexLuthr
Copy link
Collaborator

@LexLuthr LexLuthr commented Jan 11, 2023

Fixes #1047

@LexLuthr LexLuthr requested a review from dirkmc January 11, 2023 10:40
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move common code into a function shared by processOfflineDealProposal and processDealProposal.

Please test this out with a local devnet and paste the results into the issue description (or as a comment)

@LexLuthr
Copy link
Collaborator Author

I tested this on devnet.

With a filter.

boost offline-deal --verified=false --provider=t01000 --commp=baga6ea4seaqpfonfro6j3gcw4uxkxbivlqn2fghx5dpulc6sbi5noz7bcvzmuiq --car-size=1175 --piece-size=2048 --payload-cid=bafk2bzacec3jst4tkh424chatp273o6rxvipfg54kphd56gaxobpcdtr2sgco --storage-price 20000000000
Error: deal proposal rejected: sh: 1: /var/lib/boost/script.sh: Permission denied

Without a filter

boost offline-deal --verified=false --provider=t01000 --commp=baga6ea4seaqpfonfro6j3gcw4uxkxbivlqn2fghx5dpulc6sbi5noz7bcvzmuiq --car-size=1175 --piece-size=2048 --payload-cid=bafk2bzacec3jst4tkh424chatp273o6rxvipfg54kphd56gaxobpcdtr2sgco --storage-price 20000000000
sent deal proposal for offline deal
  deal uuid: 4557b034-9941-4168-b3b5-0cb896e29193
  storage provider: t01000
  client wallet: t3wzwsvv3d23aqag6nfxnpao76olnoa5oom6grezs4vuo6mmi3u36jhlw33uflliwytbakn7dptz33saspjsaq
  payload cid: bafk2bzacec3jst4tkh424chatp273o6rxvipfg54kphd56gaxobpcdtr2sgco
  commp: baga6ea4seaqpfonfro6j3gcw4uxkxbivlqn2fghx5dpulc6sbi5noz7bcvzmuiq
  start epoch: 6453
  end epoch: 524853
  provider collateral: 0

Screenshot 2023-01-11 at 5 35 28 PM

@LexLuthr LexLuthr requested a review from dirkmc January 11, 2023 12:07
@LexLuthr LexLuthr merged commit 8904030 into main Jan 11, 2023
@LexLuthr LexLuthr deleted the fix/offline-deal-filter branch January 11, 2023 13:04
@s0nik42
Copy link

s0nik42 commented Jan 12, 2023

I confirm that:

  • it works as expected with CIDgravity for deal accepted
  • REgarding the deal rejected by CIDgravity, I cannot see them in boost.

In boost :
image

In CIDgravity :

image

dirkmc added a commit that referenced this pull request Jan 13, 2023
* feat: client flag to not announce deals (#1051)

* client flag to announce deals

* fix itest

* apply suggestions

* test: fix announce tests

* refactor: remove dead code

* fix: TestCancelTransferForTransferredDealFails

* fix var names

* fix typo

* refactor test

* fix double negative

* change flag names

* change defaults value to false

Co-authored-by: Dirk McCormick <[email protected]>

* fix: vacuum db after log cleanup (#1059)

* vacuum db

* fix syntax

* vacuum at startup

* log error

* fix: run deal filter for offline deals (#1067)

* run deal filter for offline deals

* move filters to common func

* fix: deal status on transfer complete (#1066)

* fix: sort sealing worker list by date (#1074)

Co-authored-by: LexLuthr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Offline deals doesn't trigger Deal Filter
3 participants