Make Prove{CommitSectors, ReplicaUpdates}3Params aggregate proof type optional #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Jan 30, 2024
rvagg
reviewed
Jan 30, 2024
magik6k
approved these changes
Feb 1, 2024
arajasek
force-pushed
the
anorth/ddo-aggprooftype
branch
from
b683e83 to
ed15f73
Compare
arajasek
approved these changes
Feb 1, 2024
arajasek
reviewed
Feb 1, 2024
| @@ -490,8 +490,8 @@ pub struct ProveReplicaUpdates3Params { | |||
| pub aggregate_proof: RawBytes, | |||
| // The proof type for all sector update proofs, individually or before aggregation. | |||
| pub update_proofs_type: RegisteredUpdateProof, | |||
| // The proof type for the aggregate proof (ignored if no aggregate proof). | |||
| pub aggregate_proof_type: RegisteredAggregateProof, | |||
| // The proof type for the aggregate proof (must be None if no aggregate proof). | |||
There was a problem hiding this comment.
Nit: This isn't actually true today, afaic tell -- this field is simply ignored in all cases (cuz we don't actually support aggregated PRUs yet), and so you can put whatever you want in here?
There was a problem hiding this comment.
Right, I'll fix so it is enforced, so that doesn't break anyone in the future when we need to.
anorth
force-pushed
the
anorth/ddo-aggprooftype
branch
from
af2e86c to
fc78384
Compare
rjan90
pushed a commit
that referenced
this pull request
Feb 8, 2024
… optional (#1511) * Make Prove{CommitSectors, ReplicaUpdates}3Params aggregate proof type optional. * Enforce no agg proof type when not used
rjan90
pushed a commit
that referenced
this pull request
Feb 8, 2024
… optional (#1511) * Make Prove{CommitSectors, ReplicaUpdates}3Params aggregate proof type optional. * Enforce no agg proof type when not used
rjan90
added a commit
that referenced
this pull request
Feb 8, 2024
* Make Prove{CommitSectors, ReplicaUpdates}3Params aggregate proof type optional (#1511)
* Make Prove{CommitSectors, ReplicaUpdates}3Params aggregate proof type optional.
* Enforce no agg proof type when not used
* Serialise bigint as idiomatic Filecoin form (#1516)
Without this it naively serialises using the underlying Rust BigInt
representation:
[sign,[data,data,...]]
---------
Co-authored-by: Alex North <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require a corresponding update to the FIP.