Add market state invariants and fix a mistake in tests. #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
commented
Feb 9, 2024
| // Other deal clean-up is deferred to per-epoch cron. | ||
| // Note there may be some deal states that are not removed here, | ||
| // despite deletion of this mapping, e.g. for expired but not-yet-settled deals. | ||
| // The sector->deal mapping is no longer needed (the deal state has sector number too). | ||
| let all_deal_ids = st.pop_sector_deal_ids( |
There was a problem hiding this comment.
This line removes all provider-sector-deal mappings for the sectors, so the deleted code below was a no-op.
| &[id0, id1], | ||
| ); | ||
| assert_deal_deleted(&rt, id0, &deal0, sector_number); | ||
| assert_deal_deleted(&rt, id1, &deal1, sector_number); | ||
| assert_deal_deleted(&rt, id1, &deal2, sector_number); |
There was a problem hiding this comment.
This mistake (id1) was introduced when synchronous deal termination was introduced. The test made a lot more sense before that, and just remains relevant.
rvagg
approved these changes
Feb 9, 2024
rvagg
reviewed
Feb 9, 2024
rvagg
reviewed
Feb 9, 2024
@rvagg Yes (if you felt inspired to do that, that would be awesome!). |
arajasek
approved these changes
Feb 9, 2024
Co-authored-by: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds market-internal state invariants between deal stats and provider-sector-deal mapping.