Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Safe docs on addresses from other chains #2344

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

eshon
Copy link
Collaborator

@eshon eshon commented Dec 18, 2024

No description provided.

@longfeiWan9 longfeiWan9 merged commit 36a56ba into filecoin-project:main Dec 19, 2024
1 check failed
@eshon
Copy link
Collaborator Author

eshon commented Dec 19, 2024

@longfeiWan9 - All linkChecker issues need to be resolved before merge. Otherwise it can mess up the Gitbook deployment.

If there are any red X's next to any commits like above, then those issues need to be resolved first by the original PR-maker or the person doing the merge. Otherwise there's no point in having a CI test process for PRs.

@longfeiWan9
Copy link
Member

@eshon is it not working for a while and giving a lot of false alarms? I do not want the false alarms to block minor document changes. It is confusing if it works or not.
I suggest whoever submits PR should ensure all the checks are green. Otherwise, this PR should stay in the draft or not-ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants