Update to unified go graphsync v0.9.0 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to go-graphsync v0.8.0 with go-ipld-prime linksystem branch & trusted store.
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
=======================================
Coverage 67.97% 67.97%
=======================================
Files 24 24
Lines 3066 3066
=======================================
Hits 2084 2084
Misses 627 627
Partials 355 355
Continue to review full report at Codecov.
|
This was referenced Aug 27, 2021
ribasushi
approved these changes
Aug 27, 2021
it's been far too long| peer "github.com/libp2p/go-libp2p-core/peer" | ||
| cbg "github.com/whyrusleeping/cbor-gen" | ||
| xerrors "golang.org/x/xerrors" | ||
| ) | ||
|
|
||
| var _ = xerrors.Errorf | ||
| var _ = cid.Undef | ||
| var _ = sort.Sort |
There was a problem hiding this comment.
Really surprised this is needed... ( the .Sort specifically, not the cid.Undef )
raulk
approved these changes
Aug 28, 2021
There was a problem hiding this comment.
This seems like simple interface change adaptation. LGTM, but @aarshkshah1992 and @dirkmc should sign off too.
dirkmc
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
This is based on #212, but rebased on master and updated to go-graphsync v0.9.0 which incorporates all the changes from the v0.6.x branch. It is part of the effort to unify graphsync versions post M1