fix: make ClaimExtensionRequest provider type match builtin-actors (#254

) FIP says Address, builtin-actors says ActorID for both ClaimExtensionRequest and AllocationRequest. This mismatch has been in place since v10. Ref: filecoin-project/builtin-actors@686a2f2
filecoin-project · Mar 15, 2024 · 0a34ea1 · 0a34ea1
1 parent c07c5f9
commit 0a34ea1
Show file tree

Hide file tree

Showing 8 changed files with 72 additions and 32 deletions.
diff --git a/builtin/v10/verifreg/cbor_gen.go b/builtin/v10/verifreg/cbor_gen.go
diff --git a/builtin/v10/verifreg/verifreg_types.go b/builtin/v10/verifreg/verifreg_types.go
@@ -217,9 +217,13 @@ type AllocationRequest struct {
 }
 
 type ClaimExtensionRequest struct {
-	Provider addr.Address
-	Claim    ClaimId
-	TermMax  abi.ChainEpoch
+	// The provider (miner actor) which may claim the allocation.
+	Provider abi.ActorID
+	// Identifier of the claim to be extended.
+	Claim ClaimId
+	// The new maximum period for which a provider can earn quality-adjusted power
+	// for the piece (epochs).
+	TermMax abi.ChainEpoch
 }
 
 type AllocationRequests struct {

diff --git a/builtin/v11/verifreg/cbor_gen.go b/builtin/v11/verifreg/cbor_gen.go
diff --git a/builtin/v11/verifreg/verifreg_types.go b/builtin/v11/verifreg/verifreg_types.go
@@ -217,9 +217,13 @@ type AllocationRequest struct {
 }
 
 type ClaimExtensionRequest struct {
-	Provider addr.Address
-	Claim    ClaimId
-	TermMax  abi.ChainEpoch
+	// The provider (miner actor) which may claim the allocation.
+	Provider abi.ActorID
+	// Identifier of the claim to be extended.
+	Claim ClaimId
+	// The new maximum period for which a provider can earn quality-adjusted power
+	// for the piece (epochs).
+	TermMax abi.ChainEpoch
 }
 
 type AllocationRequests struct {

diff --git a/builtin/v12/verifreg/cbor_gen.go b/builtin/v12/verifreg/cbor_gen.go
diff --git a/builtin/v12/verifreg/verifreg_types.go b/builtin/v12/verifreg/verifreg_types.go
@@ -218,9 +218,13 @@ type AllocationRequest struct {
 }
 
 type ClaimExtensionRequest struct {
-	Provider addr.Address
-	Claim    ClaimId
-	TermMax  abi.ChainEpoch
+	// The provider (miner actor) which may claim the allocation.
+	Provider abi.ActorID
+	// Identifier of the claim to be extended.
+	Claim ClaimId
+	// The new maximum period for which a provider can earn quality-adjusted power
+	// for the piece (epochs).
+	TermMax abi.ChainEpoch
 }
 
 type AllocationRequests struct {

diff --git a/builtin/v13/verifreg/cbor_gen.go b/builtin/v13/verifreg/cbor_gen.go
diff --git a/builtin/v13/verifreg/verifreg_types.go b/builtin/v13/verifreg/verifreg_types.go
@@ -218,9 +218,13 @@ type AllocationRequest struct {
 }
 
 type ClaimExtensionRequest struct {
-	Provider addr.Address
-	Claim    ClaimId
-	TermMax  abi.ChainEpoch
+	// The provider (miner actor) which may claim the allocation.
+	Provider abi.ActorID
+	// Identifier of the claim to be extended.
+	Claim ClaimId
+	// The new maximum period for which a provider can earn quality-adjusted power
+	// for the piece (epochs).
+	TermMax abi.ChainEpoch
 }
 
 type AllocationRequests struct {