Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CreateExternal to eam #149

Merged
merged 5 commits into from
Jan 13, 2023
Merged

add CreateExternal to eam #149

merged 5 commits into from
Jan 13, 2023

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Jan 13, 2023

@vyzo vyzo requested review from Stebalien and arajasek January 13, 2023 18:57
arajasek
arajasek previously requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, just use CborBytes directly (see what we do for the EVM InvokeContract method)

@vyzo
Copy link
Contributor Author

vyzo commented Jan 13, 2023

ok

@vyzo
Copy link
Contributor Author

vyzo commented Jan 13, 2023

done.

@vyzo vyzo requested a review from arajasek January 13, 2023 20:08
@vyzo vyzo dismissed arajasek’s stale review January 13, 2023 20:09

implemented suggestion

@vyzo
Copy link
Contributor Author

vyzo commented Jan 13, 2023

This is a new brand of fruit, it didn't exist last time I dealt with this code.

Stebalien
Stebalien approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits but otherwise lgtm.

builtin/v10/eam/eam_types.go Outdated Show resolved Hide resolved
builtin/v10/eam/methods.go Outdated Show resolved Hide resolved
vyzo and others added 2 commits January 13, 2023 22:17
@vyzo
Copy link
Contributor Author

vyzo commented Jan 13, 2023

wait a bit, need the method in the top level methods file

@vyzo
Copy link
Contributor Author

vyzo commented Jan 13, 2023

done, this should be ready for merge

@Stebalien Stebalien merged commit ce7f035 into feat/fevm-update Jan 13, 2023
@Stebalien Stebalien deleted the feat/fevm-update-eam-refactor branch January 13, 2023 20:35
@vyzo vyzo mentioned this pull request Jan 13, 2023
Merged
2 tasks
arajasek added a commit that referenced this pull request Jan 14, 2023
@Stebalien @vyzo @arajasek
FEVM: update types (#147)
5f2a83a 
* feat: update state for selfdestruct

* EVM: fix method numbers/signatures

* add CreateExternal to eam (#149)

* add CreateExternal to eam

* use CborBytes instead of CreateExternalParams

* Update builtin/v10/eam/eam_types.go

Co-authored-by: Steven Allen <[email protected]>

* Update builtin/v10/eam/methods.go

Co-authored-by: Steven Allen <[email protected]>

* add CreateExternal to eam method list

Co-authored-by: Steven Allen <[email protected]>

* make gen for CreateExternalReturn (#150)

* Fix copypasta

Co-authored-by: vyzo <[email protected]>
Co-authored-by: Aayush Rajasekaran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@arajasek arajasek Awaiting requested review from arajasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyzo @Stebalien @arajasek