feat!: extract BatchReturn to batch package, add methods & tests #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 tasks
For now, I added a note to filecoin-project/lotus#12109 as this being an item for the "Mainnet Upgrade Release" |
|
2024-07-11 maintainer conversation: this will get merged after the |
ZenGround0
approved these changes
Jul 12, 2024
|
@rvagg @ZenGround0 what's the state of this one? |
I just need to get back to this and get it landed in the next major release .. so 🔜 |
rvagg
force-pushed
the
rvagg/batch-return
branch
from
5025381 to
1e30a73
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #286 +/- ##
==========================================
+ Coverage 3.42% 3.53% +0.10%
==========================================
Files 589 592 +3
Lines 112037 110759 -1278
==========================================
+ Hits 3837 3915 +78
+ Misses 106695 105311 -1384
- Partials 1505 1533 +28
|
rvagg
force-pushed
the
rvagg/batch-return
branch
from
1e30a73 to
494117a
Compare
ZenGround0
approved these changes
Sep 6, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started off by wanting methods on
BatchReturnto roughly match what's available in Rust, then I remembered that I was going to add serialization tests for this too because it's in the NI-PoRep path, then I realised that this struct is used in multiple actors and hasn't changed form since it was introduced. In builtin-actors it's in the shared "fil_actors_runtime" package for this very reason. So this PR introduces the same thing here:BatchReturnandFailCodeinto a new "batch" packageBatchReturn:Size(),AllOk(),Codes() []exitcode.ExitCode,CodeAt(n uint64) exitcode.ExitCodeThis is a breaking change because it removes types that were previously there. There are no current direct uses of this type within Lotus today (I'm in the process of introducing one though). This would be a good candidate to ship in a v0.14.0 final I think.