extract test utils to go-unixfsnode #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
- Coverage 71.04% 70.22% -0.82%
==========================================
Files 68 66 -2
Lines 6081 5824 -257
==========================================
- Hits 4320 4090 -230
+ Misses 1520 1501 -19
+ Partials 241 233 -8
|
willscott
approved these changes
May 12, 2023
rvagg
force-pushed
the
rvagg/wrapcontent-reusable
branch
from
15fd9d3 to
c89b7e3
Compare
rvagg
changed the title
|
merged #232 into this, renamed it to reflect what we're doing now, recreated this branch on top of the new |
hannahhoward
approved these changes
May 20, 2023
There was a problem hiding this comment.
LGTM but @rvagg can you tag unixfsnode 1.6.1 and update before you merge?
hannahhoward
approved these changes
May 20, 2023
There was a problem hiding this comment.
LGTM but @rvagg can you tag unixfsnode 1.6.1 and update before you merge?
rvagg
force-pushed
the
rvagg/wrapcontent-reusable
branch
from
c89b7e3 to
8520e95
Compare
|
1.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving a bit of test infra that I want to extract into go-unixfsnode so we can reuse it elsewhere (go-car, and here)