fix: add missing span.End() (#1202)

filecoin-project · May 11, 2023 · 0c54ee4 · 0c54ee4
1 parent 16d4ddf
commit 0c54ee4
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 3 deletions.
diff --git a/tasks/blocks/drand/task.go b/tasks/blocks/drand/task.go
@@ -28,6 +28,7 @@ func (p *Task) ProcessTipSet(ctx context.Context, ts *types.TipSet) (model.Persi
 			attribute.String("processor", "blocks"),
 		)
 	}
+	defer span.End()
 
 	var pl model.PersistableList
 	for _, bh := range ts.Blocks() {

diff --git a/tasks/blocks/headers/task.go b/tasks/blocks/headers/task.go
@@ -28,6 +28,7 @@ func (p *Task) ProcessTipSet(ctx context.Context, ts *types.TipSet) (model.Persi
 			attribute.String("processor", "blocks"),
 		)
 	}
+	defer span.End()
 
 	var pl model.PersistableList
 	for _, bh := range ts.Blocks() {

diff --git a/tasks/blocks/parents/task.go b/tasks/blocks/parents/task.go
@@ -28,6 +28,7 @@ func (p *Task) ProcessTipSet(ctx context.Context, ts *types.TipSet) (model.Persi
 			attribute.String("processor", "blocks"),
 		)
 	}
+	defer span.End()
 
 	var pl model.PersistableList
 	for _, bh := range ts.Blocks() {

diff --git a/tasks/fevmactorstats/task.go b/tasks/fevmactorstats/task.go
@@ -43,6 +43,8 @@ func (p *Task) ProcessTipSet(ctx context.Context, ts *types.TipSet) (model.Persi
 			attribute.String("processor", "fevmactorstats"),
 		)
 	}
+	defer span.End()
+
 	report := &visormodel.ProcessingReport{
 		Height:    int64(ts.Height()),
 		StateRoot: ts.ParentState().String(),

diff --git a/tasks/messages/blockmessage/task.go b/tasks/messages/blockmessage/task.go
@@ -26,7 +26,7 @@ func NewTask(node tasks.DataSource) *Task {
 }
 
 func (t *Task) ProcessTipSet(ctx context.Context, current *types.TipSet) (model.Persistable, *visormodel.ProcessingReport, error) {
-	ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSets")
+	ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSet")
 	if span.IsRecording() {
 		span.SetAttributes(
 			attribute.String("current", current.String()),

diff --git a/tasks/messages/gaseconomy/task.go b/tasks/messages/gaseconomy/task.go
@@ -29,7 +29,7 @@ func NewTask(node tasks.DataSource) *Task {
 }
 
 func (t *Task) ProcessTipSet(ctx context.Context, current *types.TipSet) (model.Persistable, *visormodel.ProcessingReport, error) {
-	ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSets")
+	ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSet")
 	if span.IsRecording() {
 		span.SetAttributes(
 			attribute.String("current", current.String()),

diff --git a/tasks/messages/message/task.go b/tasks/messages/message/task.go
@@ -27,7 +27,7 @@ func NewTask(node tasks.DataSource) *Task {
 }
 
 func (t *Task) ProcessTipSet(ctx context.Context, current *types.TipSet) (model.Persistable, *visormodel.ProcessingReport, error) {
-	ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSets")
+	ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSet")
 	if span.IsRecording() {
 		span.SetAttributes(
 			attribute.String("current", current.String()),