chore(lint): fix staticcheck linting issues

chain/indexer.go

@@ -31,7 +31,6 @@ var _ indexer.TipSetObserver = (*TipSetIndexer)(nil)
 // A TipSetWatcher waits for tipsets and persists their block data into a database.
 type TipSetIndexer struct {
 	window      time.Duration
-	opener      lens.APIOpener
 	storage     Storage
 	processors  map[string]TipSetProcessor
 	name        string

commands/setup.go

@@ -6,7 +6,6 @@ import (
 	"fmt"
 	"net/http"
 	"net/http/pprof"
-	_ "net/http/pprof"
 	"strings"
 	"time"
 

lens/lotusrepo/repo.go

@@ -26,7 +26,7 @@ import (
 	"github.com/filecoin-project/specs-actors/actors/util/adt"
 	"github.com/ipfs/go-cid"
 	cbor "github.com/ipfs/go-ipld-cbor"
-	peer "github.com/libp2p/go-libp2p-peer"
+	peer "github.com/libp2p/go-libp2p-core/peer"
 	"github.com/urfave/cli/v2"
 
 	"github.com/filecoin-project/sentinel-visor/lens"

lens/s3repo/store.go

@@ -23,7 +23,6 @@ type S3Blockstore struct {
 }
 
 func NewBlockStore(connstr string) (blockstore.Blockstore, error) {
-
 	sbs := &S3Blockstore{
 		prefix: connstr,
 		client: http.Client{},
@@ -42,7 +41,7 @@ func (sbs *S3Blockstore) Has(c cid.Cid) (has bool, err error) {
 }
 
 func (sbs *S3Blockstore) AllKeysChan(ctx context.Context) (<-chan cid.Cid, error) {
-	return nil, fmt.Errorf("Not implemented")
+	return nil, fmt.Errorf("not implemented")
 }
 
 func (sbs *S3Blockstore) Get(c cid.Cid) (blocks.Block, error) {
@@ -51,7 +50,7 @@ func (sbs *S3Blockstore) Get(c cid.Cid) (blocks.Block, error) {
 		return nil, err
 	}
 	if resp.StatusCode != http.StatusOK {
-		return nil, fmt.Errorf("Failed to fetch: %v", resp.StatusCode)
+		return nil, fmt.Errorf("failed to fetch: %v", resp.StatusCode)
 	}
 	defer resp.Body.Close()
 	buf, err := ioutil.ReadAll(resp.Body)
@@ -107,13 +106,13 @@ func (sbs *S3Blockstore) HashOnRead(enabled bool) {
 
 // Put puts a given block to the underlying datastore
 func (sbs *S3Blockstore) Put(b blocks.Block) (err error) {
-	return fmt.Errorf("Not Implemented")
+	return fmt.Errorf("not implemented")
 }
 
 func (sbs *S3Blockstore) PutMany(blks []blocks.Block) error {
-	return fmt.Errorf("Not Implemented")
+	return fmt.Errorf("not implemented")
 }
 
 func (sbs *S3Blockstore) DeleteBlock(cid.Cid) error {
-	return fmt.Errorf("Not Implemented")
+	return fmt.Errorf("not implemented")
 }

tasks/actorstate/miner.go

@@ -134,7 +134,7 @@ type MinerStateExtractionContext struct {
 }
 
 func (m *MinerStateExtractionContext) IsGenesis() bool {
-	return 0 == m.CurrTs.Height()
+	return m.CurrTs.Height() == 0
 }
 
 func ExtractMinerInfo(a ActorInfo, ec *MinerStateExtractionContext) (*minermodel.MinerInfo, error) {
@@ -620,7 +620,7 @@ type PartitionStatus struct {
 }
 
 func extractMinerPartitionsDiff(ctx context.Context, ec *MinerStateExtractionContext) (*PartitionStatus, error) {
-	ctx, span := global.Tracer("").Start(ctx, "StorageMinerExtractor.minerPartitionDiff") // nolint: ineffassign,staticcheck
+	_, span := global.Tracer("").Start(ctx, "StorageMinerExtractor.minerPartitionDiff") // nolint: ineffassign,staticcheck
 	defer span.End()
 
 	// short circuit genesis state.

tasks/actorstate/power.go

@@ -69,7 +69,7 @@ type PowerStateExtractionContext struct {
 }
 
 func (p *PowerStateExtractionContext) IsGenesis() bool {
-	return 0 == p.CurrTs.Height()
+	return p.CurrTs.Height() == 0
 }
 
 func (StoragePowerExtractor) Extract(ctx context.Context, a ActorInfo, node ActorStateAPI) (model.PersistableWithTx, error) {

tasks/indexer/chainheadindexer.go

@@ -91,7 +91,9 @@ func (c *ChainHeadIndexer) index(ctx context.Context, headEvents []*lotus_api.He
 
 			// If we have a zero confidence window then we need to notify every tipset we see
 			if c.confidence == 0 {
-				c.obs.TipSet(ctx, ch.Val)
+				if err := c.obs.TipSet(ctx, ch.Val); err != nil {
+					return xerrors.Errorf("notify tipset: %w", err)
+				}
 			}
 		case store.HCApply:
 			log.Debugw("add tipset", "height", ch.Val.Height(), "tipset", ch.Val.Key().String())
@@ -102,7 +104,9 @@ func (c *ChainHeadIndexer) index(ctx context.Context, headEvents []*lotus_api.He
 
 			// Send the tipset that fell out of the confidence window to the observer
 			if tail != nil {
-				c.obs.TipSet(ctx, tail)
+				if err := c.obs.TipSet(ctx, tail); err != nil {
+					return xerrors.Errorf("notify tipset: %w", err)
+				}
 			}
 
 		case store.HCRevert:

tasks/indexer/chainhistoryindexer.go

@@ -73,7 +73,9 @@ func (c *ChainHistoryIndexer) WalkChain(ctx context.Context, node lens.API, ts *
 	ctx, _ = tag.New(ctx, tag.Upsert(metrics.TaskType, "indexhistoryblock"))
 
 	log.Debugw("found tipset", "height", ts.Height())
-	c.obs.TipSet(ctx, ts)
+	if err := c.obs.TipSet(ctx, ts); err != nil {
+		return xerrors.Errorf("notify tipset: %w", err)
+	}
 
 	var err error
 	for int64(ts.Height()) >= c.minHeight && ts.Height() > 0 {
@@ -89,7 +91,9 @@ func (c *ChainHistoryIndexer) WalkChain(ctx context.Context, node lens.API, ts *
 		}
 
 		log.Debugw("found tipset", "height", ts.Height())
-		c.obs.TipSet(ctx, ts)
+		if err := c.obs.TipSet(ctx, ts); err != nil {
+			return xerrors.Errorf("notify tipset: %w", err)
+		}
 
 	}