Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed unused gas calc from parsedmessages #1056

Merged
merged 2 commits into from
Sep 7, 2022
Merged

fix: removed unused gas calc from parsedmessages #1056

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b3182c
fix: removed unused gas calc from parsedmessages
frrist Sep 6, 2022
77a8521
refactor: fix log with unrelated error
frrist Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions tasks/messages/parsedmessage/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ func (t *Task) ProcessTipSets(ctx context.Context, current *types.TipSet, execut
parsedMessageResults = make(messagemodel.ParsedMessages, 0)
errorsDetected = make([]*messages.MessageError, 0)
exeMsgSeen = make(map[cid.Cid]bool)
totalGasLimit int64
totalUniqGasLimit int64
)

for _, msgrec := range blkMsgRec {
Expand All @@ -100,22 +98,12 @@ func (t *Task) ProcessTipSets(ctx context.Context, current *types.TipSet, execut
return nil, nil, err
}

// calculate total gas limit of executed messages regardless of duplicates.
for itr.HasNext() {
msg, _, _ := itr.Next()
totalGasLimit += msg.VMMessage().GasLimit
}

// reset the iterator to beginning
itr.Reset()

for itr.HasNext() {
m, _, r := itr.Next()
if exeMsgSeen[m.Cid()] {
continue
}
exeMsgSeen[m.Cid()] = true
totalUniqGasLimit += m.VMMessage().GasLimit

toActorCode, found := getActorCodeFn(m.VMMessage().To)
if !found && r.ExitCode == 0 {
Expand All @@ -124,7 +112,7 @@ func (t *Task) ProcessTipSets(ctx context.Context, current *types.TipSet, execut
// unknown type.
// If the message was executed it means we are out of step with Lotus behaviour somehow. This probably
// indicates that Lily actor type detection is out of date.
log.Errorw("parsing message", "error", err, "cid", m.Cid().String(), "receipt", r)
log.Errorw("parsing message", "cid", m.Cid().String(), "receipt", r)
errorsDetected = append(errorsDetected, &messages.MessageError{
Cid: m.Cid(),
Error: fmt.Errorf("failed to parse message params: missing to actor code").Error(),
Expand Down