fix: Use bitfield.MultiMerge to improve LoadSectorState performance #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birdychang
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1086 +/- ##
========================================
- Coverage 34.3% 34.2% -0.2%
========================================
Files 44 44
Lines 2932 2945 +13
========================================
Hits 1008 1008
- Misses 1828 1841 +13
Partials 96 96 |
placer14
approved these changes
Nov 7, 2022
| func LoadSectorState(ctx context.Context, state miner.State) (*SectorStates, error) { | ||
| _, span := otel.Tracer("").Start(ctx, "LoadSectorState") | ||
| defer span.End() | ||
|
|
||
| sectorStates := &SectorStates{} |
There was a problem hiding this comment.
Suggested change
| sectorStates := &SectorStates{} |
|
|
||
| return nil | ||
| }) | ||
| }); err != nil { | ||
| return nil, err | ||
| } | ||
| var err error |
There was a problem hiding this comment.
Suggested change
| var err error | |
| var err error | |
| var sectorStates = &SectorStates{} |
|
Great initial contribution! 🙇 |
placer14
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using bitfield.MultiMerge once instead of bitfield.MergeBitFields repeatedly should reduce the time by 50%.