fix: remove actor code mapping #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1087 +/- ##
======================================
Coverage 34.3% 34.3%
======================================
Files 44 44
Lines 2932 2932
======================================
Hits 1008 1008
Misses 1828 1828
Partials 96 96 |
kasteph
reviewed
Nov 9, 2022
kasteph
reviewed
Nov 9, 2022
* refactor: polish GetActorCodeFunc - remove address resolution, its handled by lotus internally via state.GetActor
frrist
force-pushed
the
birdy/remote-actor-code-map
branch
from
60c5036 to
c545428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without actor code mapping, MakeGetActorCodeFunc & all GetActorCode calls only take a few ms to execute.
Time to construct actor code mapping with 5M state store caching takes ~10s.
Time to construct actor code mapping without caching takes ~40s.