chore(ci): Create docker images for commits in cd/staging
#1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placer14
commented
Nov 16, 2022
.circleci/config.yml
Outdated
| @@ -346,7 +303,7 @@ jobs: | |||
| # used in `build-docker-images` workflow below | |||
| branch_filters: &branch_filters | |||
| branches: | |||
| only: /.*deploy.*/ | |||
| only: /cd\/staging/ | |||
There was a problem hiding this comment.
We are reusing prior behavior. This causes us to detect changes on cd/staging and trigger this job.
placer14
commented
Nov 16, 2022
| @@ -89,7 +55,8 @@ jobs: | |||
| echo "$DOCKERHUB_PASS" | docker login -u "$DOCKERHUB_USERNAME" --password-stdin | |||
| sanitized_branch=`echo $CIRCLE_BRANCH | sed 's:/:-:g'` | |||
| tag_suffix=$(echo "$CIRCLE_SHA1" | cut -c 1-8) | |||
| make docker-mainnet-push LILY_IMAGE_TAG=${sanitized_branch}-${tag_suffix} | |||
| tag_date=$(date +%Y%m%d%H%M) | |||
| make docker-mainnet-push LILY_IMAGE_TAG=${sanitized_branch}-${tag_date}-${tag_suffix} | |||
There was a problem hiding this comment.
The new docker image tags that are created look like cd-staging-${tag_date}-${tag_suffix}. This is what we will filter on when deciding what to deploy into staging.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1090 +/- ##
======================================
Coverage 34.2% 34.2%
======================================
Files 44 44
Lines 2945 2945
======================================
Hits 1008 1008
Misses 1841 1841
Partials 96 96 |
birdychang
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes commits to the branch
cd/stagingto trigger docker image build pipeline.