Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): Cache proof params in production docker image #1101

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

placer14
Copy link
Contributor

@placer14 placer14 commented Dec 14, 2022

closes https://github.com/filecoin-project/sentinel-infra/issues/408

Note the tradeoff here is a larger image (going from ~300MB to ~700MB) in exchange for shorter startup time and avoidance of potential future issues related to transient proof downloads.

(This also means that proof changes will require a new build/release.)

@codecov-commenter
Copy link

Codecov Report

Merging #1101 (7269d8d) into master (852e26b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1101   +/-   ##
======================================
  Coverage    32.8%   32.8%           
======================================
  Files          46      46           
  Lines        3156    3156           
======================================
  Hits         1037    1037           
  Misses       2023    2023           
  Partials       96      96           

@placer14 placer14 self-assigned this Dec 14, 2022
@placer14
Copy link
Contributor Author

The integration test appears to be a failure of IPFS and not the test itself. I will be unavailable to merge this over the break. Please merge at will.

@frrist frrist self-requested a review January 9, 2023 20:11
@frrist frrist merged commit d4c08df into master Jan 9, 2023
@frrist frrist deleted the mg/chore/cache-params-in-docker-image branch January 9, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants