Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't error on unknown method numbers for FEVM #1165

Merged
merged 1 commit into from
Mar 16, 2023
Merged

fix: don't error on unknown method numbers for FEVM #1165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lens/util/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,16 @@ func ParseVmMessageReturn(ret []byte, retCodec uint64, method abi.MethodNum, act
func ParseParams(params []byte, method abi.MethodNum, actCode cid.Cid) (_ string, _ string, err error) {
m, found := ActorRegistry.Methods[actCode][method]
if !found {
return "", "", fmt.Errorf("unknown method %d for actor %s", method, actCode)
// if the method wasn't found it is likely the case the method was one of:
// https://github.com/filecoin-project/builtin-actors/blob/f5311fe735df4d9baf5f82d4b3db10f3c51688c4/actors/docs/README.md?plain=1#L31
// so we just marshal the raw value to json and bail with a warning
paramj, err := json.Marshal(params)
if err != nil {
return "", "", err
}
err = fmt.Errorf("unknown method %d for actorCode %s name %s", method, actCode, builtin.ActorNameByCode(actCode))
log.Warnw("parsing vm message params", "error", err)
return string(paramj), "Unknown", nil
}

// if the actor method doesn't expect params don't parse them
Expand Down