Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batch insert actor & actor_state data #1192

Merged
merged 4 commits into from
May 3, 2023
Merged

Conversation

birdychang
Copy link
Contributor

@birdychang birdychang commented May 3, 2023

Currently, actor state changes are stored as model.PersistableList, which doesn't support batch persistence. This PR adds a transformer to actorstate task to convert model.PersistableList to corresponding model type that supports batch persistence.
This resolves #1190.

@birdychang birdychang requested review from kasteph and Terryhung May 3, 2023 02:23
Copy link
Contributor

@kasteph kasteph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very nice, thanks!

@birdychang birdychang merged commit 6682f30 into master May 3, 2023
@birdychang birdychang deleted the birdy/batch_insert branch May 3, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Batch Insert in Lily Tasks
2 participants