feat: add new task: fevm_block_header #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2023 23:39
kasteph
reviewed
May 17, 2023
model/fevm/blockheader.go
Outdated
Comment on lines
30
to
34
| Difficulty int64 `pg:",use_zero"` | ||
| Number int64 `pg:",use_zero"` | ||
| GasLimit int64 `pg:",use_zero"` | ||
| GasUsed int64 `pg:",use_zero"` | ||
| Timestamp int64 `pg:",use_zero"` |
There was a problem hiding this comment.
Why are these int64? The Lotus implementation has these as uint64.
tasks/fevm/blockheader/tasks.go
Outdated
|
|
||
| cid, err := executed.Key().Cid() | ||
| if err != nil { | ||
| log.Errorf("Error at getting cid") |
There was a problem hiding this comment.
Suggested change
| log.Errorf("Error at getting cid") | |
| log.Errorf("Error at getting cid: [%v] err: %v", cid, err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.